Răsfoiți Sursa

[PATCH] i2c-i801: Fix block transaction poll loops

i2c-i801: Fix block transaction poll loops

Two of the three poll loops have the poll and sleep swapped,
causing an extra sleep to occur after the polled condition is
fulfilled. In practice, this doubles the amount of sleep time for
every block transaction.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jean Delvare 19 ani în urmă
părinte
comite
397e2f66a2
1 a modificat fișierele cu 2 adăugiri și 2 ștergeri
  1. 2 2
      drivers/i2c/busses/i2c-i801.c

+ 2 - 2
drivers/i2c/busses/i2c-i801.c

@@ -334,8 +334,8 @@ static int i801_block_transaction(union i2c_smbus_data *data, char read_write,
 		/* We will always wait for a fraction of a second! */
 		/* We will always wait for a fraction of a second! */
 		timeout = 0;
 		timeout = 0;
 		do {
 		do {
-			temp = inb_p(SMBHSTSTS);
 			msleep(1);
 			msleep(1);
+			temp = inb_p(SMBHSTSTS);
 		}
 		}
 		    while ((!(temp & 0x80))
 		    while ((!(temp & 0x80))
 			   && (timeout++ < MAX_TIMEOUT));
 			   && (timeout++ < MAX_TIMEOUT));
@@ -393,8 +393,8 @@ static int i801_block_transaction(union i2c_smbus_data *data, char read_write,
 		/* wait for INTR bit as advised by Intel */
 		/* wait for INTR bit as advised by Intel */
 		timeout = 0;
 		timeout = 0;
 		do {
 		do {
-			temp = inb_p(SMBHSTSTS);
 			msleep(1);
 			msleep(1);
+			temp = inb_p(SMBHSTSTS);
 		} while ((!(temp & 0x02))
 		} while ((!(temp & 0x02))
 			   && (timeout++ < MAX_TIMEOUT));
 			   && (timeout++ < MAX_TIMEOUT));