Browse Source

[SCSI] lpfc: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: James Smart <James.Smart@Emulex.Com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Julia Lawall 16 years ago
parent
commit
372bd28290
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/scsi/lpfc/lpfc_init.c

+ 2 - 1
drivers/scsi/lpfc/lpfc_init.c

@@ -1795,12 +1795,13 @@ lpfc_block_mgmt_io(struct lpfc_hba * phba)
 int
 int
 lpfc_online(struct lpfc_hba *phba)
 lpfc_online(struct lpfc_hba *phba)
 {
 {
-	struct lpfc_vport *vport = phba->pport;
+	struct lpfc_vport *vport;
 	struct lpfc_vport **vports;
 	struct lpfc_vport **vports;
 	int i;
 	int i;
 
 
 	if (!phba)
 	if (!phba)
 		return 0;
 		return 0;
+	vport = phba->pport;
 
 
 	if (!(vport->fc_flag & FC_OFFLINE_MODE))
 	if (!(vport->fc_flag & FC_OFFLINE_MODE))
 		return 0;
 		return 0;