瀏覽代碼

OMAP: DSS2: OMAPFB: Add null pointer check

A null pointer check added. And using kstrdup()
instead of kmalloc() & strcpy()

Signed-off-by: Samreen <samreen@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Samreen 14 年之前
父節點
當前提交
36e8c27f3b
共有 1 個文件被更改,包括 3 次插入2 次删除
  1. 3 2
      drivers/video/omap2/omapfb/omapfb-main.c

+ 3 - 2
drivers/video/omap2/omapfb/omapfb-main.c

@@ -2132,8 +2132,9 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev)
 	char *str, *options, *this_opt;
 	int r = 0;
 
-	str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
-	strcpy(str, def_mode);
+	str = kstrdup(def_mode, GFP_KERNEL);
+	if (!str)
+		return -ENOMEM;
 	options = str;
 
 	while (!r && (this_opt = strsep(&options, ",")) != NULL) {