Browse Source

USB: TI 3410/5052 USB Serial Driver: Fix mem leak when firmware is too big.

If the size of the firmware exceeds TI_FIRMWARE_BUF_SIZE we'll leak 'fw_p'
by failing to call release_firmware().
This patch fixes the leak.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jesper Juhl 14 years ago
parent
commit
357f45db92
1 changed files with 1 additions and 0 deletions
  1. 1 0
      drivers/usb/serial/ti_usb_3410_5052.c

+ 1 - 0
drivers/usb/serial/ti_usb_3410_5052.c

@@ -1745,6 +1745,7 @@ static int ti_download_firmware(struct ti_device *tdev)
 	}
 	if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
 		dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);
+		release_firmware(fw_p);
 		return -ENOENT;
 	}