Browse Source

ktest: Strip off '\n' when reading which files were modified

The patchcheck test looks at what files are modified for each patch it
checks and makes sure that those files do not produce any warnings.

Unfortunately, when it read the diffstat, the newlines were added on the
files and this made compares miss warnings, and commits that should not
have passed, ktest let pass.

Fix this by using the perl command "chomp" that strips off whitespace at
the end of lines.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Steven Rostedt (Red Hat) 12 years ago
parent
commit
35275685bf
1 changed files with 4 additions and 0 deletions
  1. 4 0
      tools/testing/ktest/ktest.pl

+ 4 - 0
tools/testing/ktest/ktest.pl

@@ -1925,6 +1925,10 @@ sub check_buildlog {
 
     my @files = `git show $patch | diffstat -l`;
 
+    foreach my $file (@files) {
+	chomp $file;
+    }
+
     open(IN, "git show $patch |") or
 	dodie "failed to show $patch";
     while (<IN>) {