Browse Source

[PATCH] tty: remove useless memory barrier

I don't see why there is a memory barrier in copy_from_read_buf() at all.
Even if it was useful spin_unlock_irqrestore implies a barrier.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Ralf Baechle 18 years ago
parent
commit
34f8f0a5e9
1 changed files with 0 additions and 1 deletions
  1. 0 1
      drivers/char/n_tty.c

+ 0 - 1
drivers/char/n_tty.c

@@ -1151,7 +1151,6 @@ static int copy_from_read_buf(struct tty_struct *tty,
 	n = min(*nr, n);
 	n = min(*nr, n);
 	spin_unlock_irqrestore(&tty->read_lock, flags);
 	spin_unlock_irqrestore(&tty->read_lock, flags);
 	if (n) {
 	if (n) {
-		mb();
 		retval = copy_to_user(*b, &tty->read_buf[tty->read_tail], n);
 		retval = copy_to_user(*b, &tty->read_buf[tty->read_tail], n);
 		n -= retval;
 		n -= retval;
 		spin_lock_irqsave(&tty->read_lock, flags);
 		spin_lock_irqsave(&tty->read_lock, flags);