소스 검색

NFC: double unlock in nfc_llcp_recv_connect()

We unlock inside the if block on the other side of this if else
statement.  It could result in calling mutex_unlock() twice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Dan Carpenter 13 년 전
부모
커밋
341ee4349f
1개의 변경된 파일1개의 추가작업 그리고 3개의 파일을 삭제
  1. 1 3
      net/nfc/llcp/llcp.c

+ 1 - 3
net/nfc/llcp/llcp.c

@@ -554,11 +554,9 @@ static void nfc_llcp_recv_connect(struct nfc_llcp_local *local,
 				goto enqueue;
 				goto enqueue;
 			}
 			}
 		}
 		}
-
+		mutex_unlock(&local->socket_lock);
 	}
 	}
 
 
-	mutex_unlock(&local->socket_lock);
-
 	reason = LLCP_DM_NOBOUND;
 	reason = LLCP_DM_NOBOUND;
 	goto fail;
 	goto fail;