|
@@ -2237,15 +2237,15 @@ static ssize_t iwl_dbgfs_log_event_read(struct file *file,
|
|
|
size_t count, loff_t *ppos)
|
|
|
{
|
|
|
struct iwl_priv *priv = file->private_data;
|
|
|
- char *buf;
|
|
|
- int pos = 0;
|
|
|
- ssize_t ret = -ENOMEM;
|
|
|
+ char *buf = NULL;
|
|
|
+ ssize_t ret;
|
|
|
|
|
|
- ret = pos = iwl_dump_nic_event_log(priv, true, &buf, true);
|
|
|
- if (buf) {
|
|
|
- ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
|
|
|
- kfree(buf);
|
|
|
- }
|
|
|
+ ret = iwl_dump_nic_event_log(priv, true, &buf, true);
|
|
|
+ if (ret < 0)
|
|
|
+ goto err;
|
|
|
+ ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
|
|
|
+err:
|
|
|
+ kfree(buf);
|
|
|
return ret;
|
|
|
}
|
|
|
|