Browse Source

atm: fore200e: Fix build warning.

GCC (rightfully) complains that:

drivers/atm/fore200e.c:614:5: warning: operation on 'cmdq->head' may be undefined

This is due to the FORE200E_NEXT_ENTRY macro, which essentially
evaluates to:

	i = ++i % m

Make it what's explicitly intended here which is:

	i = (i + 1) % m

and the warning goes away.

Signed-off-by: David S. Miller <davem@davemloft.net>
David S. Miller 14 years ago
parent
commit
30dfe2c050
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/atm/fore200e.c

+ 1 - 1
drivers/atm/fore200e.c

@@ -92,7 +92,7 @@
 
 
 #define FORE200E_INDEX(virt_addr, type, index)     (&((type *)(virt_addr))[ index ])
 #define FORE200E_INDEX(virt_addr, type, index)     (&((type *)(virt_addr))[ index ])
 
 
-#define FORE200E_NEXT_ENTRY(index, modulo)         (index = ++(index) % (modulo))
+#define FORE200E_NEXT_ENTRY(index, modulo)         (index = ((index) + 1) % (modulo))
 
 
 #if 1
 #if 1
 #define ASSERT(expr)     if (!(expr)) { \
 #define ASSERT(expr)     if (!(expr)) { \