Browse Source

KVM: Remove three magic numbers

There are several places where hardcoded numbers are used in place of
the easily-available constant, which is poor form.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Rusty Russell 18 years ago
parent
commit
3077c4513c
2 changed files with 2 additions and 2 deletions
  1. 1 1
      drivers/kvm/kvm_main.c
  2. 1 1
      drivers/kvm/svm.c

+ 1 - 1
drivers/kvm/kvm_main.c

@@ -413,7 +413,7 @@ static void free_pio_guest_pages(struct kvm_vcpu *vcpu)
 {
 {
 	int i;
 	int i;
 
 
-	for (i = 0; i < 2; ++i)
+	for (i = 0; i < ARRAY_SIZE(vcpu->pio.guest_pages); ++i)
 		if (vcpu->pio.guest_pages[i]) {
 		if (vcpu->pio.guest_pages[i]) {
 			__free_page(vcpu->pio.guest_pages[i]);
 			__free_page(vcpu->pio.guest_pages[i]);
 			vcpu->pio.guest_pages[i] = NULL;
 			vcpu->pio.guest_pages[i] = NULL;

+ 1 - 1
drivers/kvm/svm.c

@@ -241,7 +241,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu)
 		printk(KERN_DEBUG "%s: NOP\n", __FUNCTION__);
 		printk(KERN_DEBUG "%s: NOP\n", __FUNCTION__);
 		return;
 		return;
 	}
 	}
-	if (svm->next_rip - svm->vmcb->save.rip > 15) {
+	if (svm->next_rip - svm->vmcb->save.rip > MAX_INST_SIZE) {
 		printk(KERN_ERR "%s: ip 0x%llx next 0x%llx\n",
 		printk(KERN_ERR "%s: ip 0x%llx next 0x%llx\n",
 		       __FUNCTION__,
 		       __FUNCTION__,
 		       svm->vmcb->save.rip,
 		       svm->vmcb->save.rip,