Browse Source

wl1271: Remove circular interlocking related to the inetaddr notifier chain

Removing the wl1271 from the inet addr notifier chain sometimes causes the
registered handler to be called - causing locking problems if the removing
function is called from within the mutex.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Juuso Oikarinen 15 years ago
parent
commit
2ea9fb3d79
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/net/wireless/wl12xx/wl1271_main.c

+ 2 - 1
drivers/net/wireless/wl12xx/wl1271_main.c

@@ -1029,12 +1029,13 @@ static void wl1271_op_remove_interface(struct ieee80211_hw *hw,
 	struct wl1271 *wl = hw->priv;
 	int i;
 
+	unregister_inetaddr_notifier(&wl1271_dev_notifier);
+
 	mutex_lock(&wl->mutex);
 	wl1271_debug(DEBUG_MAC80211, "mac80211 remove interface");
 
 	wl1271_info("down");
 
-	unregister_inetaddr_notifier(&wl1271_dev_notifier);
 	list_del(&wl->list);
 
 	WARN_ON(wl->state != WL1271_STATE_ON);