S2io: two branches the same in wait_for_cmd_complete() · 2d146eb172 - Gogs

S2io: two branches the same in wait_for_cmd_complete()

Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET. 
Reported by Roel Kluin <roel.kluin@gmail.com>.

Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Ram Vepa 15 years ago

parent

dad48a4ef2

commit

2d146eb172

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
drivers/net/s2io.c
							 
								View File
							
				@@ -3421,7 +3421,7 @@ static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
			
				 				break;
			
				 			}
			
				 		} else {
			
				-			if (!(val64 & busy_bit)) {
			
				+			if (val64 & busy_bit) {
			
				 				ret = SUCCESS;
			
				 				break;
			
				 			}