Browse Source

[media] dvb-usb: improve sanity check of adap->active_fe in dvb_usb_ctrl_feed

The check for (adap->active_fe < 0) at the top of dvb_usb_ctrl_feed is a sanity
check to ensure that adap->active_fe is valid.  Improve that sanity check
by also checking for (adap->active_fe >= adap->num_frontends_initialized)

Signed-off-by: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Michael Krufky 14 years ago
parent
commit
2d04c13a50
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/media/dvb/dvb-usb/dvb-usb-dvb.c

+ 2 - 1
drivers/media/dvb/dvb-usb/dvb-usb-dvb.c

@@ -17,7 +17,8 @@ static int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
 	if (adap == NULL)
 		return -ENODEV;
 
-	if (adap->active_fe < 0) {
+	if ((adap->active_fe < 0) ||
+	    (adap->active_fe >= adap->num_frontends_initialized)) {
 		return -EINVAL;
 	}