Browse Source

GPIO: clps711x: use platform_device_unregister in gpio_clps711x_init()

platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.

Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in error
cases.  All other usage is a bug.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Wei Yongjun 12 years ago
parent
commit
2cad6a8a4c
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/gpio/gpio-clps711x.c

+ 1 - 2
drivers/gpio/gpio-clps711x.c

@@ -162,8 +162,7 @@ static int __init gpio_clps711x_init(void)
 			    GFP_KERNEL);
 	if (!gpio) {
 		dev_err(&pdev->dev, "GPIO allocating memory error\n");
-		platform_device_del(pdev);
-		platform_device_put(pdev);
+		platform_device_unregister(pdev);
 		return -ENOMEM;
 	}