Browse Source

drivers/net/atl1c: Remove double test

The nic_type field is compared to athr_l2c twice.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Julia Lawall 14 years ago
parent
commit
2bc9e23465
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/atl1c/atl1c_hw.c

+ 1 - 1
drivers/net/atl1c/atl1c_hw.c

@@ -480,7 +480,7 @@ int atl1c_phy_reset(struct atl1c_hw *hw)
 		atl1c_write_phy_reg(hw, MII_DBG_DATA, 0x929D);
 		atl1c_write_phy_reg(hw, MII_DBG_DATA, 0x929D);
 	}
 	}
 	if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b2
 	if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b2
-		|| hw->nic_type == athr_l2c || hw->nic_type == athr_l2c) {
+		|| hw->nic_type == athr_l2c) {
 		atl1c_write_phy_reg(hw, MII_DBG_ADDR, 0x29);
 		atl1c_write_phy_reg(hw, MII_DBG_ADDR, 0x29);
 		atl1c_write_phy_reg(hw, MII_DBG_DATA, 0xB6DD);
 		atl1c_write_phy_reg(hw, MII_DBG_DATA, 0xB6DD);
 	}
 	}