瀏覽代碼

leds: Fix led-gpio active_low default brightness

When gpio_direction_output() is called, led_dat->active_low is used
as default value. This means that the led will always be off by
default. cdev.brightness should really have been set to LED_OFF
unconditionally to reflect this behavior.

Signed-off-by: Raphael Assenat <raph@8d.com>
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Raphael Assenat 17 年之前
父節點
當前提交
2b7f1b8c8f
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/leds/leds-gpio.c

+ 1 - 1
drivers/leds/leds-gpio.c

@@ -85,7 +85,7 @@ static int gpio_led_probe(struct platform_device *pdev)
 		led_dat->can_sleep = gpio_cansleep(cur_led->gpio);
 		led_dat->can_sleep = gpio_cansleep(cur_led->gpio);
 		led_dat->active_low = cur_led->active_low;
 		led_dat->active_low = cur_led->active_low;
 		led_dat->cdev.brightness_set = gpio_led_set;
 		led_dat->cdev.brightness_set = gpio_led_set;
-		led_dat->cdev.brightness = cur_led->active_low ? LED_FULL : LED_OFF;
+		led_dat->cdev.brightness = LED_OFF;
 
 
 		ret = gpio_request(led_dat->gpio, led_dat->cdev.name);
 		ret = gpio_request(led_dat->gpio, led_dat->cdev.name);
 		if (ret < 0)
 		if (ret < 0)