Browse Source

headers_install: check exit status of unifdef

If unifdef fails for any reason (like segfaulting), we should be aborting
the install steps.  So check its exit status in this unlikely scenario.

Reported-by: Diego Elio Pettenò <flameeyes@gentoo.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Mike Frysinger 14 years ago
parent
commit
2979076fbf
1 changed files with 7 additions and 0 deletions
  1. 7 0
      scripts/headers_install.pl

+ 7 - 0
scripts/headers_install.pl

@@ -45,6 +45,13 @@ foreach my $file (@files) {
 	close $in;
 	close $in;
 
 
 	system $unifdef . " $tmpfile > $installdir/$file";
 	system $unifdef . " $tmpfile > $installdir/$file";
+	# unifdef will exit 0 on success, and will exit 1 when the
+	# file was processed successfully but no changes were made,
+	# so abort only when it's higher than that.
+	my $e = $? >> 8;
+	if ($e > 1) {
+		die "$tmpfile: $!\n";
+	}
 	unlink $tmpfile;
 	unlink $tmpfile;
 }
 }
 exit 0;
 exit 0;