Эх сурвалжийг харах

unregister_blkdev(): do WARN_ON on failure

When unregister_blkdev() has failed, something wrong happened.  This patch
adds WARN_ON to notify of such badness.

Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Akinobu Mita 18 жил өмнө
parent
commit
294462a5c6
1 өөрчлөгдсөн 3 нэмэгдсэн , 2 устгасан
  1. 3 2
      block/genhd.c

+ 3 - 2
block/genhd.c

@@ -120,9 +120,10 @@ int unregister_blkdev(unsigned int major, const char *name)
 	for (n = &major_names[index]; *n; n = &(*n)->next)
 	for (n = &major_names[index]; *n; n = &(*n)->next)
 		if ((*n)->major == major)
 		if ((*n)->major == major)
 			break;
 			break;
-	if (!*n || strcmp((*n)->name, name))
+	if (!*n || strcmp((*n)->name, name)) {
+		WARN_ON(1);
 		ret = -EINVAL;
 		ret = -EINVAL;
-	else {
+	} else {
 		p = *n;
 		p = *n;
 		*n = p->next;
 		*n = p->next;
 	}
 	}