Przeglądaj źródła

[media] uvcvideo: Cleanup leftovers of partial revert

Commit ba68c8530a263dc4de440fa10bb20a1c5b9d4ff5 (Partly revert "[media]
uvcvideo: Set error_idx properly for extended controls API failures")
missed two modifications. Clean them up.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Laurent Pinchart 12 lat temu
rodzic
commit
29005c09f4
1 zmienionych plików z 2 dodań i 5 usunięć
  1. 2 5
      drivers/media/usb/uvc/uvc_v4l2.c

+ 2 - 5
drivers/media/usb/uvc/uvc_v4l2.c

@@ -657,8 +657,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
 			ret = uvc_ctrl_get(chain, ctrl);
 			ret = uvc_ctrl_get(chain, ctrl);
 			if (ret < 0) {
 			if (ret < 0) {
 				uvc_ctrl_rollback(handle);
 				uvc_ctrl_rollback(handle);
-				ctrls->error_idx = ret == -ENOENT
-						 ? ctrls->count : i;
+				ctrls->error_idx = i;
 				return ret;
 				return ret;
 			}
 			}
 		}
 		}
@@ -686,9 +685,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
 			ret = uvc_ctrl_set(chain, ctrl);
 			ret = uvc_ctrl_set(chain, ctrl);
 			if (ret < 0) {
 			if (ret < 0) {
 				uvc_ctrl_rollback(handle);
 				uvc_ctrl_rollback(handle);
-				ctrls->error_idx = (ret == -ENOENT &&
-						    cmd == VIDIOC_S_EXT_CTRLS)
-						 ? ctrls->count : i;
+				ctrls->error_idx = i;
 				return ret;
 				return ret;
 			}
 			}
 		}
 		}