Explorar o código

bsg: add cheasy error checks for sysfs stuff

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Jens Axboe %!s(int64=18) %!d(string=hai) anos
pai
achega
264a047218
Modificáronse 1 ficheiros con 10 adicións e 1 borrados
  1. 10 1
      block/bsg.c

+ 10 - 1
block/bsg.c

@@ -983,10 +983,19 @@ int bsg_register_disk(struct gendisk *disk)
 	bsg_device_nr++;
 	bsg_device_nr++;
 	bcd->disk = disk;
 	bcd->disk = disk;
 	bcd->class_dev = class_device_create(bsg_class, NULL, dev, bcd->dev, "%s", disk->disk_name);
 	bcd->class_dev = class_device_create(bsg_class, NULL, dev, bcd->dev, "%s", disk->disk_name);
+	if (!bcd->class_dev)
+		goto err;
 	list_add_tail(&bcd->list, &bsg_class_list);
 	list_add_tail(&bcd->list, &bsg_class_list);
-	sysfs_create_link(&q->kobj, &bcd->class_dev->kobj, "bsg");
+	if (sysfs_create_link(&q->kobj, &bcd->class_dev->kobj, "bsg"))
+		goto err;
 	mutex_unlock(&bsg_mutex);
 	mutex_unlock(&bsg_mutex);
 	return 0;
 	return 0;
+err:
+	bsg_device_nr--;
+	if (bcd->class_dev)
+		class_device_destroy(bsg_class, MKDEV(BSG_MAJOR, bcd->minor));
+	mutex_unlock(&bsg_mutex);
+	return -ENOMEM;
 }
 }
 
 
 static int __init bsg_init(void)
 static int __init bsg_init(void)