Procházet zdrojové kódy

Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6:
  cifs: mark CONFIG_CIFS_NFSD_EXPORT as BROKEN
  cifs: free blkcipher in smbhash
Linus Torvalds před 14 roky
rodič
revize
258e43fdb0
2 změnil soubory, kde provedl 3 přidání a 5 odebrání
  1. 1 1
      fs/cifs/Kconfig
  2. 2 4
      fs/cifs/smbencrypt.c

+ 1 - 1
fs/cifs/Kconfig

@@ -156,6 +156,6 @@ config CIFS_ACL
 
 
 config CIFS_NFSD_EXPORT
 config CIFS_NFSD_EXPORT
 	  bool "Allow nfsd to export CIFS file system (EXPERIMENTAL)"
 	  bool "Allow nfsd to export CIFS file system (EXPERIMENTAL)"
-	  depends on CIFS && EXPERIMENTAL
+	  depends on CIFS && EXPERIMENTAL && BROKEN
 	  help
 	  help
 	   Allows NFS server to export a CIFS mounted share (nfsd over cifs)
 	   Allows NFS server to export a CIFS mounted share (nfsd over cifs)

+ 2 - 4
fs/cifs/smbencrypt.c

@@ -90,12 +90,10 @@ smbhash(unsigned char *out, const unsigned char *in, unsigned char *key)
 	sg_init_one(&sgout, out, 8);
 	sg_init_one(&sgout, out, 8);
 
 
 	rc = crypto_blkcipher_encrypt(&desc, &sgout, &sgin, 8);
 	rc = crypto_blkcipher_encrypt(&desc, &sgout, &sgin, 8);
-	if (rc) {
+	if (rc)
 		cERROR(1, "could not encrypt crypt key rc: %d\n", rc);
 		cERROR(1, "could not encrypt crypt key rc: %d\n", rc);
-		crypto_free_blkcipher(tfm_des);
-		goto smbhash_err;
-	}
 
 
+	crypto_free_blkcipher(tfm_des);
 smbhash_err:
 smbhash_err:
 	return rc;
 	return rc;
 }
 }