浏览代码

pci: use pci_ioremap_bar() in drivers/serial

Use the newly introduced pci_ioremap_bar() function in drivers/serial.
pci_ioremap_bar() just takes a pci device and a bar number, with the goal
of making it really hard to get wrong, while also having a central place
to stick sanity checks.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Arjan van de Ven 16 年之前
父节点
当前提交
24ed3abaa1
共有 2 个文件被更改,包括 3 次插入6 次删除
  1. 2 4
      drivers/serial/8250_pci.c
  2. 1 2
      drivers/serial/icom.c

+ 2 - 4
drivers/serial/8250_pci.c

@@ -398,8 +398,7 @@ static int sbs_init(struct pci_dev *dev)
 {
 {
 	u8 __iomem *p;
 	u8 __iomem *p;
 
 
-	p = ioremap_nocache(pci_resource_start(dev, 0),
-						pci_resource_len(dev, 0));
+	p = pci_ioremap_bar(dev, 0);
 
 
 	if (p == NULL)
 	if (p == NULL)
 		return -ENOMEM;
 		return -ENOMEM;
@@ -423,8 +422,7 @@ static void __devexit sbs_exit(struct pci_dev *dev)
 {
 {
 	u8 __iomem *p;
 	u8 __iomem *p;
 
 
-	p = ioremap_nocache(pci_resource_start(dev, 0),
-					pci_resource_len(dev, 0));
+	p = pci_ioremap_bar(dev, 0);
 	/* FIXME: What if resource_len < OCT_REG_CR_OFF */
 	/* FIXME: What if resource_len < OCT_REG_CR_OFF */
 	if (p != NULL)
 	if (p != NULL)
 		writeb(0, p + OCT_REG_CR_OFF);
 		writeb(0, p + OCT_REG_CR_OFF);

+ 1 - 2
drivers/serial/icom.c

@@ -1548,8 +1548,7 @@ static int __devinit icom_probe(struct pci_dev *dev,
 		goto probe_exit1;
 		goto probe_exit1;
 	}
 	}
 
 
-	 icom_adapter->base_addr = ioremap(icom_adapter->base_addr_pci,
-						pci_resource_len(dev, 0));
+	 icom_adapter->base_addr = pci_ioremap_bar(dev, 0);
 
 
 	if (!icom_adapter->base_addr)
 	if (!icom_adapter->base_addr)
 		goto probe_exit1;
 		goto probe_exit1;