Browse Source

lguest: avoid using NR_CPUS as a bounds check.

NR_CPUS (being a host number) is an arbitrary limit for the Guest.
Using the array size directly (which currently happes to be NR_CPUS)
is more futureproof.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Rusty Russell 17 years ago
parent
commit
24adf12722
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/lguest/lguest_user.c

+ 1 - 1
drivers/lguest/lguest_user.c

@@ -102,7 +102,7 @@ static ssize_t read(struct file *file, char __user *user, size_t size,loff_t*o)
 static int lg_cpu_start(struct lg_cpu *cpu, unsigned id, unsigned long start_ip)
 static int lg_cpu_start(struct lg_cpu *cpu, unsigned id, unsigned long start_ip)
 {
 {
 	/* We have a limited number the number of CPUs in the lguest struct. */
 	/* We have a limited number the number of CPUs in the lguest struct. */
-	if (id >= NR_CPUS)
+	if (id >= ARRAY_SIZE(cpu->lg->cpus))
 		return -EINVAL;
 		return -EINVAL;
 
 
 	/* Set up this CPU's id, and pointer back to the lguest struct. */
 	/* Set up this CPU's id, and pointer back to the lguest struct. */