Browse Source

nfsd: fix NULL pointer dereference in cld_pipe_downcall

If we find that "cup" is NULL in this case, then we obviously don't
want to dereference it. What we really want to print in this case
is the xid that we copied off earlier.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Jeff Layton 13 years ago
parent
commit
21f72c9f0a
1 changed files with 1 additions and 2 deletions
  1. 1 2
      fs/nfsd/nfs4recover.c

+ 1 - 2
fs/nfsd/nfs4recover.c

@@ -602,8 +602,7 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
 
 
 	/* couldn't find upcall? */
 	/* couldn't find upcall? */
 	if (!cup) {
 	if (!cup) {
-		dprintk("%s: couldn't find upcall -- xid=%u\n", __func__,
-			cup->cu_msg.cm_xid);
+		dprintk("%s: couldn't find upcall -- xid=%u\n", __func__, xid);
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}