浏览代码

NET: netpoll, fix potential NULL ptr dereference

Stanse found that one error path in netpoll_setup dereferences npinfo
even though it is NULL. Avoid that by adding new label and go to that
instead.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Daniel Borkmann <danborkmann@googlemail.com>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: chavey@google.com
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Jiri Slaby 15 年之前
父节点
当前提交
21edbb223e
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      net/core/netpoll.c

+ 2 - 2
net/core/netpoll.c

@@ -735,7 +735,7 @@ int netpoll_setup(struct netpoll *np)
 		npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL);
 		npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL);
 		if (!npinfo) {
 		if (!npinfo) {
 			err = -ENOMEM;
 			err = -ENOMEM;
-			goto release;
+			goto put;
 		}
 		}
 
 
 		npinfo->rx_flags = 0;
 		npinfo->rx_flags = 0;
@@ -845,7 +845,7 @@ int netpoll_setup(struct netpoll *np)
 
 
 		kfree(npinfo);
 		kfree(npinfo);
 	}
 	}
-
+put:
 	dev_put(ndev);
 	dev_put(ndev);
 	return err;
 	return err;
 }
 }