Browse Source

powerpc/numa: Avoid possible reference beyond prop. length in find_min_common_depth()

find_min_common_depth() was checking the property length incorrectly.
The value is in bytes not cells, and it is using the second entry.

Signed-off-By: Milton Miller <miltonm@bga.com>

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Milton Miller 16 years ago
parent
commit
20fcefe5a0
1 changed files with 1 additions and 1 deletions
  1. 1 1
      arch/powerpc/mm/numa.c

+ 1 - 1
arch/powerpc/mm/numa.c

@@ -289,7 +289,7 @@ static int __init find_min_common_depth(void)
 	ref_points = of_get_property(rtas_root,
 			"ibm,associativity-reference-points", &len);
 
-	if ((len >= 1) && ref_points) {
+	if ((len >= 2 * sizeof(unsigned int)) && ref_points) {
 		depth = ref_points[1];
 	} else {
 		dbg("NUMA: ibm,associativity-reference-points not found.\n");