Răsfoiți Sursa

leds: leds-ss4200: fix led_classdev_unregister twice in error handling

In current implementation, if device_create_file failed in register_nasgpio_led,
led_classdev_unregister will be executed twice.
( in register_nasgpio_led it calls led_classdev_unregister before return and in nas_gpio_init out_err )

This patch fixes it by only unregistering those that were successfully registered in out_err.
( not including last failed register_nasgpio_led call )

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Dave Hansen <dave@sr71.net>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Axel Lin 15 ani în urmă
părinte
comite
1e653accf7
1 a modificat fișierele cu 1 adăugiri și 1 ștergeri
  1. 1 1
      drivers/leds/leds-ss4200.c

+ 1 - 1
drivers/leds/leds-ss4200.c

@@ -534,7 +534,7 @@ static int __init nas_gpio_init(void)
 	set_power_light_amber_noblink();
 	return 0;
 out_err:
-	for (; i >= 0; i--)
+	for (i--; i >= 0; i--)
 		unregister_nasgpio_led(i);
 	pci_unregister_driver(&nas_gpio_pci_driver);
 	return ret;