Browse Source

[IPX]: Use proc_create() to setup ->proc_fops first

Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Wang Chen 17 years ago
parent
commit
1e15dc981d
1 changed files with 4 additions and 7 deletions
  1. 4 7
      net/ipx/ipx_proc.c

+ 4 - 7
net/ipx/ipx_proc.c

@@ -358,22 +358,19 @@ int __init ipx_proc_init(void)
 
 
 	if (!ipx_proc_dir)
 	if (!ipx_proc_dir)
 		goto out;
 		goto out;
-	p = create_proc_entry("interface", S_IRUGO, ipx_proc_dir);
+	p = proc_create("interface", S_IRUGO,
+			ipx_proc_dir, &ipx_seq_interface_fops);
 	if (!p)
 	if (!p)
 		goto out_interface;
 		goto out_interface;
 
 
-	p->proc_fops = &ipx_seq_interface_fops;
-	p = create_proc_entry("route", S_IRUGO, ipx_proc_dir);
+	p = proc_create("route", S_IRUGO, ipx_proc_dir, &ipx_seq_route_fops);
 	if (!p)
 	if (!p)
 		goto out_route;
 		goto out_route;
 
 
-	p->proc_fops = &ipx_seq_route_fops;
-	p = create_proc_entry("socket", S_IRUGO, ipx_proc_dir);
+	p = proc_create("socket", S_IRUGO, ipx_proc_dir, &ipx_seq_socket_fops);
 	if (!p)
 	if (!p)
 		goto out_socket;
 		goto out_socket;
 
 
-	p->proc_fops = &ipx_seq_socket_fops;
-
 	rc = 0;
 	rc = 0;
 out:
 out:
 	return rc;
 	return rc;