Browse Source

atm: Bad locking on br2684_devs modifications.

The list_del happens under read-locked devs_lock.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Pavel Emelyanov 17 years ago
parent
commit
1e0ba0060f
1 changed files with 2 additions and 2 deletions
  1. 2 2
      net/atm/br2684.c

+ 2 - 2
net/atm/br2684.c

@@ -346,9 +346,9 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
 		/* skb==NULL means VCC is being destroyed */
 		/* skb==NULL means VCC is being destroyed */
 		br2684_close_vcc(brvcc);
 		br2684_close_vcc(brvcc);
 		if (list_empty(&brdev->brvccs)) {
 		if (list_empty(&brdev->brvccs)) {
-			read_lock(&devs_lock);
+			write_lock_irq(&devs_lock);
 			list_del(&brdev->br2684_devs);
 			list_del(&brdev->br2684_devs);
-			read_unlock(&devs_lock);
+			write_unlock_irq(&devs_lock);
 			unregister_netdev(net_dev);
 			unregister_netdev(net_dev);
 		}
 		}
 		return;
 		return;