瀏覽代碼

[SCSI] st: fix gcc 4.4 warning

This patch fixes the GCC 4.4 warning reported by David Binderman and Sergey
Senozhatsky. The old version was working correctly but was not easy to read.

Signed-off-by: Kai Makisara <kai.makisara@kolumbus.fi>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Kai Makisara 16 年之前
父節點
當前提交
1da2019fff
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/scsi/st.c

+ 1 - 1
drivers/scsi/st.c

@@ -2964,7 +2964,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
 			    !(STp->use_pf & PF_TESTED)) {
 			    !(STp->use_pf & PF_TESTED)) {
 				/* Try the other possible state of Page Format if not
 				/* Try the other possible state of Page Format if not
 				   already tried */
 				   already tried */
-				STp->use_pf = !STp->use_pf | PF_TESTED;
+				STp->use_pf = (STp->use_pf ^ USE_PF) | PF_TESTED;
 				st_release_request(SRpnt);
 				st_release_request(SRpnt);
 				SRpnt = NULL;
 				SRpnt = NULL;
 				return st_int_ioctl(STp, cmd_in, arg);
 				return st_int_ioctl(STp, cmd_in, arg);