Browse Source

[CPUFREQ][1/2] ondemand: updated tune for hardware coordination

Try to make dbs_check_cpu() call on all CPUs at the same jiffy.
This will help when multiple cores share P-states via Hardware Coordination.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi at intel.com>
Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy at intel.com>
Signed-off-by: Dave Jones <davej@redhat.com>
Alexey Starikovskiy 19 years ago
parent
commit
1ce28d6b19
1 changed files with 8 additions and 5 deletions
  1. 8 5
      drivers/cpufreq/cpufreq_ondemand.c

+ 8 - 5
drivers/cpufreq/cpufreq_ondemand.c

@@ -305,6 +305,9 @@ static void do_dbs_timer(void *data)
 {
 {
 	unsigned int cpu = smp_processor_id();
 	unsigned int cpu = smp_processor_id();
 	struct cpu_dbs_info_s *dbs_info = &per_cpu(cpu_dbs_info, cpu);
 	struct cpu_dbs_info_s *dbs_info = &per_cpu(cpu_dbs_info, cpu);
+	/* We want all CPUs to do sampling nearly on same jiffy */
+	int delay = usecs_to_jiffies(dbs_tuners_ins.sampling_rate);
+	delay -= jiffies % delay;
 
 
 	if (!dbs_info->enable)
 	if (!dbs_info->enable)
 		return;
 		return;
@@ -312,18 +315,18 @@ static void do_dbs_timer(void *data)
 	lock_cpu_hotplug();
 	lock_cpu_hotplug();
 	dbs_check_cpu(dbs_info);
 	dbs_check_cpu(dbs_info);
 	unlock_cpu_hotplug();
 	unlock_cpu_hotplug();
-	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work,
-			usecs_to_jiffies(dbs_tuners_ins.sampling_rate));
+	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work, delay);
 }
 }
 
 
 static inline void dbs_timer_init(unsigned int cpu)
 static inline void dbs_timer_init(unsigned int cpu)
 {
 {
 	struct cpu_dbs_info_s *dbs_info = &per_cpu(cpu_dbs_info, cpu);
 	struct cpu_dbs_info_s *dbs_info = &per_cpu(cpu_dbs_info, cpu);
+	/* We want all CPUs to do sampling nearly on same jiffy */
+	int delay = usecs_to_jiffies(dbs_tuners_ins.sampling_rate);
+	delay -= jiffies % delay;
 
 
 	INIT_WORK(&dbs_info->work, do_dbs_timer, 0);
 	INIT_WORK(&dbs_info->work, do_dbs_timer, 0);
-	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work,
-			usecs_to_jiffies(dbs_tuners_ins.sampling_rate));
-	return;
+	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work, delay);
 }
 }
 
 
 static inline void dbs_timer_exit(struct cpu_dbs_info_s *dbs_info)
 static inline void dbs_timer_exit(struct cpu_dbs_info_s *dbs_info)