Browse Source

tipc: relocate/coalesce node cast in tipc_named_node_up

Functions like this are called using unsigned longs from
function pointers.  In this case, the function is passed in
a node which is normally internally treated as a u32 by TIPC.

Rather than add more casts into this function in the future
for each added use of node within, move the cast to a single
place on a local.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Paul Gortmaker 13 years ago
parent
commit
1c553bb52e
1 changed files with 3 additions and 2 deletions
  1. 3 2
      net/tipc/name_distr.c

+ 3 - 2
net/tipc/name_distr.c

@@ -173,13 +173,14 @@ void tipc_named_withdraw(struct publication *publ)
  * tipc_named_node_up - tell specified node about all publications by this node
  * tipc_named_node_up - tell specified node about all publications by this node
  */
  */
 
 
-void tipc_named_node_up(unsigned long node)
+void tipc_named_node_up(unsigned long nodearg)
 {
 {
 	struct tipc_node *n_ptr;
 	struct tipc_node *n_ptr;
 	struct link *l_ptr;
 	struct link *l_ptr;
 	struct publication *publ;
 	struct publication *publ;
 	struct distr_item *item = NULL;
 	struct distr_item *item = NULL;
 	struct sk_buff *buf = NULL;
 	struct sk_buff *buf = NULL;
+	u32 node = (u32)nodearg;
 	u32 left = 0;
 	u32 left = 0;
 	u32 rest;
 	u32 rest;
 	u32 max_item_buf = 0;
 	u32 max_item_buf = 0;
@@ -187,7 +188,7 @@ void tipc_named_node_up(unsigned long node)
 	/* compute maximum amount of publication data to send per message */
 	/* compute maximum amount of publication data to send per message */
 
 
 	read_lock_bh(&tipc_net_lock);
 	read_lock_bh(&tipc_net_lock);
-	n_ptr = tipc_node_find((u32)node);
+	n_ptr = tipc_node_find(node);
 	if (n_ptr) {
 	if (n_ptr) {
 		tipc_node_lock(n_ptr);
 		tipc_node_lock(n_ptr);
 		l_ptr = n_ptr->active_links[0];
 		l_ptr = n_ptr->active_links[0];