Browse Source

pinctrl: imx: Catch no fsl,pins property

Instead of crashing the kernel print an error message when
the fsl,pins property is missing.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Sascha Hauer 12 years ago
parent
commit
1bf1fea95f
1 changed files with 5 additions and 0 deletions
  1. 5 0
      drivers/pinctrl/pinctrl-imx.c

+ 5 - 0
drivers/pinctrl/pinctrl-imx.c

@@ -456,6 +456,11 @@ static int imx_pinctrl_parse_groups(struct device_node *np,
 	 * do sanity check and calculate pins number
 	 */
 	list = of_get_property(np, "fsl,pins", &size);
+	if (!list) {
+		dev_err(info->dev, "no fsl,pins property in node %s\n", np->full_name);
+		return -EINVAL;
+	}
+
 	/* we do not check return since it's safe node passed down */
 	if (!size || size % pin_size) {
 		dev_err(info->dev, "Invalid fsl,pins property in node %s\n", np->full_name);