Sfoglia il codice sorgente

drivers/isdn/mISDN/stack.c: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  The dereferences are just deleted from the
debugging statement.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Julia Lawall 13 anni fa
parent
commit
1b9faf5e66
1 ha cambiato i file con 2 aggiunte e 2 eliminazioni
  1. 2 2
      drivers/isdn/mISDN/stack.c

+ 2 - 2
drivers/isdn/mISDN/stack.c

@@ -135,8 +135,8 @@ send_layer2(struct mISDNstack *st, struct sk_buff *skb)
 			skb = NULL;
 			skb = NULL;
 		else if (*debug & DEBUG_SEND_ERR)
 		else if (*debug & DEBUG_SEND_ERR)
 			printk(KERN_DEBUG
 			printk(KERN_DEBUG
-			       "%s ch%d mgr prim(%x) addr(%x) err %d\n",
-			       __func__, ch->nr, hh->prim, ch->addr, ret);
+			       "%s mgr prim(%x) err %d\n",
+			       __func__, hh->prim, ret);
 	}
 	}
 out:
 out:
 	mutex_unlock(&st->lmutex);
 	mutex_unlock(&st->lmutex);