Quellcode durchsuchen

[CIFS] add extra null attr check

Although attr == NULL can not happen, this makes cifs_set_file_info safer
in the future since it may not be obvious that the caller can not set
attr to NULL.

Signed-off-by: Steve French <sfrench@us.ibm.com>
Steve French vor 16 Jahren
Ursprung
Commit
1adcb71092
1 geänderte Dateien mit 3 neuen und 0 gelöschten Zeilen
  1. 3 0
      fs/cifs/inode.c

+ 3 - 0
fs/cifs/inode.c

@@ -763,6 +763,9 @@ cifs_set_file_info(struct inode *inode, struct iattr *attrs, int xid,
 	struct cifsTconInfo *pTcon = cifs_sb->tcon;
 	FILE_BASIC_INFO	info_buf;
 
+	if (attrs == NULL)
+		return -EINVAL;
+
 	if (attrs->ia_valid & ATTR_ATIME) {
 		set_time = true;
 		info_buf.LastAccessTime =