Explorar o código

KVM: x86 emulator: Fix HLT instruction

This patch fixes issue encountered with HLT instruction
under FreeDOS's HIMEM XMS Driver.

The HLT instruction jumped directly to the done label and
skips updating the EIP value, therefore causing the guest
to spin endlessly on the same instruction.

The patch changes the instruction so that it writes back
the updated EIP value.

Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
Mohammed Gamal %!s(int64=17) %!d(string=hai) anos
pai
achega
19fdfa0d13
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      arch/x86/kvm/x86_emulate.c

+ 1 - 1
arch/x86/kvm/x86_emulate.c

@@ -1731,7 +1731,7 @@ special_insn:
 		break;
 		break;
 	case 0xf4:              /* hlt */
 	case 0xf4:              /* hlt */
 		ctxt->vcpu->arch.halt_request = 1;
 		ctxt->vcpu->arch.halt_request = 1;
-		goto done;
+		break;
 	case 0xf5:	/* cmc */
 	case 0xf5:	/* cmc */
 		/* complement carry flag from eflags reg */
 		/* complement carry flag from eflags reg */
 		ctxt->eflags ^= EFLG_CF;
 		ctxt->eflags ^= EFLG_CF;