Browse Source

Input: keyboard - don't override beep with a bell

The commit 66d2a5952eab875f1286e04f738ef029afdaf013 introduces a bug:
for every beep requested, a bell is also generated.

Reported-by: Paul Martin <pm@debian.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Dmitry Torokhov 15 năm trước cách đây
mục cha
commit
18f7ad59b0
1 tập tin đã thay đổi với 7 bổ sung3 xóa
  1. 7 3
      drivers/char/keyboard.c

+ 7 - 3
drivers/char/keyboard.c

@@ -233,7 +233,8 @@ int setkeycode(unsigned int scancode, unsigned int keycode)
 }
 }
 
 
 /*
 /*
- * Making beeps and bells.
+ * Making beeps and bells. Note that we prefer beeps to bells, but when
+ * shutting the sound off we do both.
  */
  */
 
 
 static int kd_sound_helper(struct input_handle *handle, void *data)
 static int kd_sound_helper(struct input_handle *handle, void *data)
@@ -242,9 +243,12 @@ static int kd_sound_helper(struct input_handle *handle, void *data)
 	struct input_dev *dev = handle->dev;
 	struct input_dev *dev = handle->dev;
 
 
 	if (test_bit(EV_SND, dev->evbit)) {
 	if (test_bit(EV_SND, dev->evbit)) {
-		if (test_bit(SND_TONE, dev->sndbit))
+		if (test_bit(SND_TONE, dev->sndbit)) {
 			input_inject_event(handle, EV_SND, SND_TONE, *hz);
 			input_inject_event(handle, EV_SND, SND_TONE, *hz);
-		if (test_bit(SND_BELL, handle->dev->sndbit))
+			if (*hz)
+				return 0;
+		}
+		if (test_bit(SND_BELL, dev->sndbit))
 			input_inject_event(handle, EV_SND, SND_BELL, *hz ? 1 : 0);
 			input_inject_event(handle, EV_SND, SND_BELL, *hz ? 1 : 0);
 	}
 	}