Browse Source

[SCSI] qla2xxx: Don't issue set or get port param MBC if invalid port loop id

Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Madhuranath Iyengar 15 years ago
parent
commit
17cf2c5d76
1 changed files with 7 additions and 0 deletions
  1. 7 0
      drivers/scsi/qla2xxx/qla_bsg.c

+ 7 - 0
drivers/scsi/qla2xxx/qla_bsg.c

@@ -1222,6 +1222,13 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job)
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}
 
 
+	if (fcport->loop_id == FC_NO_LOOP_ID) {
+		DEBUG2(printk(KERN_ERR "%s(%ld): Invalid port loop id, "
+			"loop_id = 0x%x\n",
+			__func__, vha->host_no, fcport->loop_id));
+		return -EINVAL;
+	}
+
 	if (port_param->mode)
 	if (port_param->mode)
 		rval = qla2x00_set_idma_speed(vha, fcport->loop_id,
 		rval = qla2x00_set_idma_speed(vha, fcport->loop_id,
 			port_param->speed, mb);
 			port_param->speed, mb);