Browse Source

goldfish: Add a FIXME note to the pipe driver

Note a point in the pipe driver that wants future attention

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alan Cox 12 years ago
parent
commit
17c4c9db4a
1 changed files with 1 additions and 0 deletions
  1. 1 0
      drivers/platform/goldfish/goldfish_pipe.c

+ 1 - 0
drivers/platform/goldfish/goldfish_pipe.c

@@ -300,6 +300,7 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
 		int status, wakeBit;
 
 		/* Ensure that the corresponding page is properly mapped */
+		/* FIXME: this isn't safe or sufficient - use get_user_pages */
 		if (is_write) {
 			char c;
 			/* Ensure that the page is mapped and readable */