Эх сурвалжийг харах

netxen: protect tx timeout recovery by rtnl lock

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Amit Kumar Salecha 15 жил өмнө
parent
commit
16d884bd90

+ 7 - 8
drivers/net/netxen/netxen_nic_main.c

@@ -2001,27 +2001,26 @@ static void netxen_tx_timeout_task(struct work_struct *work)
 	if (++adapter->tx_timeo_cnt >= NX_MAX_TX_TIMEOUTS)
 	if (++adapter->tx_timeo_cnt >= NX_MAX_TX_TIMEOUTS)
 		goto request_reset;
 		goto request_reset;
 
 
+	rtnl_lock();
 	if (NX_IS_REVISION_P2(adapter->ahw.revision_id)) {
 	if (NX_IS_REVISION_P2(adapter->ahw.revision_id)) {
 		/* try to scrub interrupt */
 		/* try to scrub interrupt */
 		netxen_napi_disable(adapter);
 		netxen_napi_disable(adapter);
 
 
-		adapter->netdev->trans_start = jiffies;
-
 		netxen_napi_enable(adapter);
 		netxen_napi_enable(adapter);
 
 
 		netif_wake_queue(adapter->netdev);
 		netif_wake_queue(adapter->netdev);
 
 
 		clear_bit(__NX_RESETTING, &adapter->state);
 		clear_bit(__NX_RESETTING, &adapter->state);
-		return;
 	} else {
 	} else {
 		clear_bit(__NX_RESETTING, &adapter->state);
 		clear_bit(__NX_RESETTING, &adapter->state);
-		if (!netxen_nic_reset_context(adapter)) {
-			adapter->netdev->trans_start = jiffies;
-			return;
+		if (netxen_nic_reset_context(adapter)) {
+			rtnl_unlock();
+			goto request_reset;
 		}
 		}
-
-		/* context reset failed, fall through for fw reset */
 	}
 	}
+	adapter->netdev->trans_start = jiffies;
+	rtnl_unlock();
+	return;
 
 
 request_reset:
 request_reset:
 	adapter->need_fw_reset = 1;
 	adapter->need_fw_reset = 1;