Sfoglia il codice sorgente

[SCSI] fix sdev_rw_attr macro for scsi device sysfs entries

This patch fixes sdev_rw_attr() macro for scsi device sysfs entries.
It seems there is no such function snscanf in the current linux kernel,
so it fails to compile scsi driver when someone try to add a new rw entry.
This has been unfixed for a long time probably because current scsi device
has no rw entries.

# grep snscanf . -rn
./drivers/scsi/scsi_sysfs.c:489:        snscanf (buf, 20, format_string, &sdev->field);                 \

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Tomohiro Kusumi 15 anni fa
parent
commit
160e7f6713
1 ha cambiato i file con 2 aggiunte e 2 eliminazioni
  1. 2 2
      drivers/scsi/scsi_sysfs.c

+ 2 - 2
drivers/scsi/scsi_sysfs.c

@@ -474,7 +474,7 @@ static DEVICE_ATTR(field, S_IRUGO, sdev_show_##field, NULL);
 
 
 
 
 /*
 /*
- * sdev_rd_attr: create a function and attribute variable for a
+ * sdev_rw_attr: create a function and attribute variable for a
  * read/write field.
  * read/write field.
  */
  */
 #define sdev_rw_attr(field, format_string)				\
 #define sdev_rw_attr(field, format_string)				\
@@ -486,7 +486,7 @@ sdev_store_##field (struct device *dev, struct device_attribute *attr,	\
 {									\
 {									\
 	struct scsi_device *sdev;					\
 	struct scsi_device *sdev;					\
 	sdev = to_scsi_device(dev);					\
 	sdev = to_scsi_device(dev);					\
-	snscanf (buf, 20, format_string, &sdev->field);			\
+	sscanf (buf, format_string, &sdev->field);			\
 	return count;							\
 	return count;							\
 }									\
 }									\
 static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, sdev_show_##field, sdev_store_##field);
 static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, sdev_show_##field, sdev_store_##field);