Browse Source

typhoon: wait for RX mode commands to finish

When adding VLAN devices, we can get several calls to
typhoon_set_rx_mode() in quick succession. Because we didn't wait for
the commands to complete, we could run out of command descriptors and
fail to set the RX mode.

Signed-off-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
David Dillow 14 years ago
parent
commit
154ccd82e1
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/typhoon.c

+ 1 - 1
drivers/net/typhoon.c

@@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev)
 		filter |= TYPHOON_RX_FILTER_MCAST_HASH;
 		filter |= TYPHOON_RX_FILTER_MCAST_HASH;
 	}
 	}
 
 
-	INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER);
+	INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER);
 	xp_cmd.parm1 = filter;
 	xp_cmd.parm1 = filter;
 	typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL);
 	typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL);
 }
 }