Browse Source

mbcs: cdev lock_kernel() pushdown

This driver would appear to have no internal locking at all.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Jonathan Corbet 17 years ago
parent
commit
12ead6b098
1 changed files with 5 additions and 0 deletions
  1. 5 0
      drivers/char/mbcs.c

+ 5 - 0
drivers/char/mbcs.c

@@ -24,6 +24,7 @@
 #include <linux/mm.h>
 #include <linux/mm.h>
 #include <linux/uio.h>
 #include <linux/uio.h>
 #include <linux/mutex.h>
 #include <linux/mutex.h>
+#include <linux/smp_lock.h>
 #include <asm/io.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
 #include <asm/uaccess.h>
 #include <asm/system.h>
 #include <asm/system.h>
@@ -382,15 +383,19 @@ static int mbcs_open(struct inode *ip, struct file *fp)
 	struct mbcs_soft *soft;
 	struct mbcs_soft *soft;
 	int minor;
 	int minor;
 
 
+	lock_kernel();
 	minor = iminor(ip);
 	minor = iminor(ip);
 
 
+	/* Nothing protects access to this list... */
 	list_for_each_entry(soft, &soft_list, list) {
 	list_for_each_entry(soft, &soft_list, list) {
 		if (soft->nasid == minor) {
 		if (soft->nasid == minor) {
 			fp->private_data = soft->cxdev;
 			fp->private_data = soft->cxdev;
+			unlock_kernel();
 			return 0;
 			return 0;
 		}
 		}
 	}
 	}
 
 
+	unlock_kernel();
 	return -ENODEV;
 	return -ENODEV;
 }
 }