|
@@ -184,14 +184,13 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
|
|
|
int i, error;
|
|
|
|
|
|
if (!pdata->rows || !pdata->cols || !pdata->keymap) {
|
|
|
- printk(KERN_ERR DRV_NAME
|
|
|
- ": No rows, cols or keymap from pdata\n");
|
|
|
+ dev_err(&pdev->dev, "no rows, cols or keymap from pdata\n");
|
|
|
return -EINVAL;
|
|
|
}
|
|
|
|
|
|
if (!pdata->keymapsize ||
|
|
|
pdata->keymapsize > (pdata->rows * pdata->cols)) {
|
|
|
- printk(KERN_ERR DRV_NAME ": Invalid keymapsize\n");
|
|
|
+ dev_err(&pdev->dev, "invalid keymapsize\n");
|
|
|
return -EINVAL;
|
|
|
}
|
|
|
|
|
@@ -211,8 +210,8 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
|
|
|
|
|
|
if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
|
|
|
!pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
|
|
|
- printk(KERN_WARNING DRV_NAME
|
|
|
- ": Invalid Debounce/Columndrive Time in platform data\n");
|
|
|
+ dev_warn(&pdev->dev,
|
|
|
+ "invalid platform debounce/columndrive time\n");
|
|
|
bfin_write_KPAD_MSEL(0xFF0); /* Default MSEL */
|
|
|
} else {
|
|
|
bfin_write_KPAD_MSEL(
|
|
@@ -231,16 +230,14 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
|
|
|
|
|
|
if (peripheral_request_list((u16 *)&per_rows[MAX_RC - pdata->rows],
|
|
|
DRV_NAME)) {
|
|
|
- printk(KERN_ERR DRV_NAME
|
|
|
- ": Requesting Peripherals failed\n");
|
|
|
+ dev_err(&pdev->dev, "requesting peripherals failed\n");
|
|
|
error = -EFAULT;
|
|
|
goto out0;
|
|
|
}
|
|
|
|
|
|
if (peripheral_request_list((u16 *)&per_cols[MAX_RC - pdata->cols],
|
|
|
DRV_NAME)) {
|
|
|
- printk(KERN_ERR DRV_NAME
|
|
|
- ": Requesting Peripherals failed\n");
|
|
|
+ dev_err(&pdev->dev, "requesting peripherals failed\n");
|
|
|
error = -EFAULT;
|
|
|
goto out1;
|
|
|
}
|
|
@@ -254,9 +251,8 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
|
|
|
error = request_irq(bf54x_kpad->irq, bfin_kpad_isr,
|
|
|
0, DRV_NAME, pdev);
|
|
|
if (error) {
|
|
|
- printk(KERN_ERR DRV_NAME
|
|
|
- ": unable to claim irq %d; error %d\n",
|
|
|
- bf54x_kpad->irq, error);
|
|
|
+ dev_err(&pdev->dev, "unable to claim irq %d\n",
|
|
|
+ bf54x_kpad->irq);
|
|
|
goto out2;
|
|
|
}
|
|
|
|
|
@@ -297,8 +293,7 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
|
|
|
|
|
|
error = input_register_device(input);
|
|
|
if (error) {
|
|
|
- printk(KERN_ERR DRV_NAME
|
|
|
- ": Unable to register input device (%d)\n", error);
|
|
|
+ dev_err(&pdev->dev, "unable to register input device\n");
|
|
|
goto out4;
|
|
|
}
|
|
|
|
|
@@ -316,9 +311,6 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
|
|
|
|
|
|
device_init_wakeup(&pdev->dev, 1);
|
|
|
|
|
|
- printk(KERN_ERR DRV_NAME
|
|
|
- ": Blackfin BF54x Keypad registered IRQ %d\n", bf54x_kpad->irq);
|
|
|
-
|
|
|
return 0;
|
|
|
|
|
|
out4:
|