浏览代码

bridge: Fix RCU race in br_multicast_stop

Thanks to Paul McKenny for pointing out that it is incorrect to use
synchronize_rcu_bh to ensure that pending callbacks have completed.
Instead we should use rcu_barrier_bh.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Herbert Xu 15 年之前
父节点
当前提交
10cc2b50eb
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      net/bridge/br_multicast.c

+ 1 - 1
net/bridge/br_multicast.c

@@ -1135,7 +1135,7 @@ void br_multicast_stop(struct net_bridge *br)
 
 
 	if (mdb->old) {
 	if (mdb->old) {
 		spin_unlock_bh(&br->multicast_lock);
 		spin_unlock_bh(&br->multicast_lock);
-		synchronize_rcu_bh();
+		rcu_barrier_bh();
 		spin_lock_bh(&br->multicast_lock);
 		spin_lock_bh(&br->multicast_lock);
 		WARN_ON(mdb->old);
 		WARN_ON(mdb->old);
 	}
 	}