瀏覽代碼

[SCSI] libiscsi: Drop host lock in queuecommand

The driver does not need the host lock in queuecommand so drop it.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Mike Christie 17 年之前
父節點
當前提交
1040c99d9f
共有 1 個文件被更改,包括 5 次插入1 次删除
  1. 5 1
      drivers/scsi/libiscsi.c

+ 5 - 1
drivers/scsi/libiscsi.c

@@ -1010,8 +1010,9 @@ int iscsi_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *))
 	sc->SCp.ptr = NULL;
 	sc->SCp.ptr = NULL;
 
 
 	host = sc->device->host;
 	host = sc->device->host;
-	session = iscsi_hostdata(host->hostdata);
+	spin_unlock(host->host_lock);
 
 
+	session = iscsi_hostdata(host->hostdata);
 	spin_lock(&session->lock);
 	spin_lock(&session->lock);
 
 
 	/*
 	/*
@@ -1077,11 +1078,13 @@ int iscsi_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *))
 	spin_unlock(&session->lock);
 	spin_unlock(&session->lock);
 
 
 	scsi_queue_work(host, &conn->xmitwork);
 	scsi_queue_work(host, &conn->xmitwork);
+	spin_lock(host->host_lock);
 	return 0;
 	return 0;
 
 
 reject:
 reject:
 	spin_unlock(&session->lock);
 	spin_unlock(&session->lock);
 	debug_scsi("cmd 0x%x rejected (%d)\n", sc->cmnd[0], reason);
 	debug_scsi("cmd 0x%x rejected (%d)\n", sc->cmnd[0], reason);
+	spin_lock(host->host_lock);
 	return SCSI_MLQUEUE_HOST_BUSY;
 	return SCSI_MLQUEUE_HOST_BUSY;
 
 
 fault:
 fault:
@@ -1091,6 +1094,7 @@ fault:
 	sc->result = (DID_NO_CONNECT << 16);
 	sc->result = (DID_NO_CONNECT << 16);
 	scsi_set_resid(sc, scsi_bufflen(sc));
 	scsi_set_resid(sc, scsi_bufflen(sc));
 	sc->scsi_done(sc);
 	sc->scsi_done(sc);
+	spin_lock(host->host_lock);
 	return 0;
 	return 0;
 }
 }
 EXPORT_SYMBOL_GPL(iscsi_queuecommand);
 EXPORT_SYMBOL_GPL(iscsi_queuecommand);