Преглед на файлове

Protect manipulation of c0_status against preemption and multithreading.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Ralf Baechle преди 19 години
родител
ревизия
101b3531a6
променени са 2 файла, в които са добавени 47 реда и са изтрити 12 реда
  1. 31 8
      arch/mips/kernel/ptrace.c
  2. 16 4
      arch/mips/kernel/ptrace32.c

+ 31 - 8
arch/mips/kernel/ptrace.c

@@ -33,6 +33,7 @@
 #include <asm/dsp.h>
 #include <asm/dsp.h>
 #include <asm/fpu.h>
 #include <asm/fpu.h>
 #include <asm/mipsregs.h>
 #include <asm/mipsregs.h>
+#include <asm/mipsmtregs.h>
 #include <asm/pgtable.h>
 #include <asm/pgtable.h>
 #include <asm/page.h>
 #include <asm/page.h>
 #include <asm/system.h>
 #include <asm/system.h>
@@ -126,10 +127,21 @@ int ptrace_getfpregs (struct task_struct *child, __u32 __user *data)
 
 
 		__put_user (child->thread.fpu.hard.fcr31, data + 64);
 		__put_user (child->thread.fpu.hard.fcr31, data + 64);
 
 
-		flags = read_c0_status();
-		__enable_fpu();
-		__asm__ __volatile__("cfc1\t%0,$0" : "=r" (tmp));
-		write_c0_status(flags);
+		preempt_disable();
+		if (cpu_has_mipsmt) {
+			unsigned int vpflags = dvpe();
+			flags = read_c0_status();
+			__enable_fpu();
+			__asm__ __volatile__("cfc1\t%0,$0" : "=r" (tmp));
+			write_c0_status(flags);
+			evpe(vpflags);
+		} else {
+			flags = read_c0_status();
+			__enable_fpu();
+			__asm__ __volatile__("cfc1\t%0,$0" : "=r" (tmp));
+			write_c0_status(flags);
+		}
+		preempt_enable();
 		__put_user (tmp, data + 65);
 		__put_user (tmp, data + 65);
 	} else {
 	} else {
 		__put_user (child->thread.fpu.soft.fcr31, data + 64);
 		__put_user (child->thread.fpu.soft.fcr31, data + 64);
@@ -284,10 +296,21 @@ asmlinkage int sys_ptrace(long request, long pid, long addr, long data)
 			if (!cpu_has_fpu)
 			if (!cpu_has_fpu)
 				break;
 				break;
 
 
-			flags = read_c0_status();
-			__enable_fpu();
-			__asm__ __volatile__("cfc1\t%0,$0": "=r" (tmp));
-			write_c0_status(flags);
+			preempt_disable();
+			if (cpu_has_mipsmt) {
+				unsigned int vpflags = dvpe();
+				flags = read_c0_status();
+				__enable_fpu();
+				__asm__ __volatile__("cfc1\t%0,$0": "=r" (tmp));
+				write_c0_status(flags);
+				evpe(vpflags);
+			} else {
+				flags = read_c0_status();
+				__enable_fpu();
+				__asm__ __volatile__("cfc1\t%0,$0": "=r" (tmp));
+				write_c0_status(flags);
+			}
+			preempt_enable();
 			break;
 			break;
 		}
 		}
 		case DSP_BASE ... DSP_BASE + 5: {
 		case DSP_BASE ... DSP_BASE + 5: {

+ 16 - 4
arch/mips/kernel/ptrace32.c

@@ -29,6 +29,7 @@
 #include <asm/dsp.h>
 #include <asm/dsp.h>
 #include <asm/fpu.h>
 #include <asm/fpu.h>
 #include <asm/mipsregs.h>
 #include <asm/mipsregs.h>
+#include <asm/mipsmtregs.h>
 #include <asm/pgtable.h>
 #include <asm/pgtable.h>
 #include <asm/page.h>
 #include <asm/page.h>
 #include <asm/system.h>
 #include <asm/system.h>
@@ -191,10 +192,21 @@ asmlinkage int sys32_ptrace(int request, int pid, int addr, int data)
 			if (!cpu_has_fpu)
 			if (!cpu_has_fpu)
 				break;
 				break;
 
 
-			flags = read_c0_status();
-			__enable_fpu();
-			__asm__ __volatile__("cfc1\t%0,$0": "=r" (tmp));
-			write_c0_status(flags);
+			preempt_disable();
+			if (cpu_has_mipsmt) {
+				unsigned int vpflags = dvpe();
+				flags = read_c0_status();
+				__enable_fpu();
+				__asm__ __volatile__("cfc1\t%0,$0": "=r" (tmp));
+				write_c0_status(flags);
+				evpe(vpflags);
+			} else {
+				flags = read_c0_status();
+				__enable_fpu();
+				__asm__ __volatile__("cfc1\t%0,$0": "=r" (tmp));
+				write_c0_status(flags);
+			}
+			preempt_enable();
 			break;
 			break;
 		}
 		}
 		case DSP_BASE ... DSP_BASE + 5:
 		case DSP_BASE ... DSP_BASE + 5: