Browse Source

x86-32: make sure virt_addr_valid() returns false for fixmap addresses

I found that virt_addr_valid() was returning true for fixmap addresses.

I'm not sure whether pfn_valid() is supposed to include this test,
but there's no harm in being explicit.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <49B166D6.2080505@goop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Jeremy Fitzhardinge 16 years ago
parent
commit
0feca851c1
1 changed files with 2 additions and 0 deletions
  1. 2 0
      arch/x86/mm/ioremap.c

+ 2 - 0
arch/x86/mm/ioremap.c

@@ -87,6 +87,8 @@ bool __virt_addr_valid(unsigned long x)
 		return false;
 		return false;
 	if (__vmalloc_start_set && is_vmalloc_addr((void *) x))
 	if (__vmalloc_start_set && is_vmalloc_addr((void *) x))
 		return false;
 		return false;
+	if (x >= FIXADDR_START)
+		return false;
 	return pfn_valid((x - PAGE_OFFSET) >> PAGE_SHIFT);
 	return pfn_valid((x - PAGE_OFFSET) >> PAGE_SHIFT);
 }
 }
 EXPORT_SYMBOL(__virt_addr_valid);
 EXPORT_SYMBOL(__virt_addr_valid);