Преглед изворни кода

[PATCH] x86-64/i386: Don't process APICs/IO-APICs in ACPI when APIC is disabled.

When nolapic was passed or the local APIC was disabled
for another reason ACPI would still parse the IO-APICs
until these were explicitely disabled with noapic.

Usually this resulted in a non booting configuration unless
"nolapic noapic" was used.

I also disabled the local APIC parsing in this case, although
that's only cosmetic (suppresses a few printks)

This hopefully makes nolapic work in all cases.

Cc: Len Brown <len.brown@intel.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Andi Kleen пре 19 година
родитељ
комит
0fcd270901
1 измењених фајлова са 4 додато и 1 уклоњено
  1. 4 1
      arch/i386/kernel/acpi/boot.c

+ 4 - 1
arch/i386/kernel/acpi/boot.c

@@ -168,7 +168,7 @@ int __init acpi_parse_mcfg(unsigned long phys_addr, unsigned long size)
 	unsigned long i;
 	unsigned long i;
 	int config_size;
 	int config_size;
 
 
-	if (!phys_addr || !size)
+	if (!phys_addr || !size || !cpu_has_apic)
 		return -EINVAL;
 		return -EINVAL;
 
 
 	mcfg = (struct acpi_table_mcfg *)__acpi_map_table(phys_addr, size);
 	mcfg = (struct acpi_table_mcfg *)__acpi_map_table(phys_addr, size);
@@ -693,6 +693,9 @@ static int __init acpi_parse_madt_lapic_entries(void)
 {
 {
 	int count;
 	int count;
 
 
+	if (!cpu_has_apic)
+		return -ENODEV;
+
 	/* 
 	/* 
 	 * Note that the LAPIC address is obtained from the MADT (32-bit value)
 	 * Note that the LAPIC address is obtained from the MADT (32-bit value)
 	 * and (optionally) overriden by a LAPIC_ADDR_OVR entry (64-bit value).
 	 * and (optionally) overriden by a LAPIC_ADDR_OVR entry (64-bit value).