浏览代码

[PATCH] Voyager: tty locking

Voyager fiddles with current->signal.tty without locking.  It turns out
that the code in question has already cleared current->signal.tty correctly
because daemonize() does the right thing already.

The signal handling also appears to be incorrect as it does an unprotected
sigfillset that also appears unneccessary.  As I don't have a bowtie and am
therefore not a qualified voyager maintainer I leave that to James.

Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Alan Cox 18 年之前
父节点
当前提交
0f0f1b400c
共有 1 个文件被更改,包括 0 次插入1 次删除
  1. 0 1
      arch/i386/mach-voyager/voyager_thread.c

+ 0 - 1
arch/i386/mach-voyager/voyager_thread.c

@@ -130,7 +130,6 @@ thread(void *unused)
 	init_timer(&wakeup_timer);
 	init_timer(&wakeup_timer);
 
 
 	sigfillset(&current->blocked);
 	sigfillset(&current->blocked);
-	current->signal->tty = NULL;
 
 
 	printk(KERN_NOTICE "Voyager starting monitor thread\n");
 	printk(KERN_NOTICE "Voyager starting monitor thread\n");